Oliver Neukum 2d4cf3d6f3
usbnet: include wait queue head in device structure ...
[ Upstream commit 14a0d635d18d0fb552dcc979d6d25106e6541f2e ]
This fixes a race which happens by freeing an object on the stack.
Quoting Julius:
> The issue is
> that it calls usbnet_terminate_urbs() before that, which temporarily
> installs a waitqueue in dev->wait in order to be able to wait on the
> tasklet to run and finish up some queues. The waiting itself looks
> okay, but the access to 'dev->wait' is totally unprotected and can
> race arbitrarily. I think in this case usbnet_bh() managed to succeed
> it's dev->wait check just before usbnet_terminate_urbs() sets it back
> to NULL. The latter then finishes and the waitqueue_t structure on its
> stack gets overwritten by other functions halfway through the
> wake_up() call in usbnet_bh().
The fix is to just not allocate the data structure on the stack.
As dev->wait is abused as a flag it also takes a runtime PM change
to fix this bug.
Signed-off-by: Oliver Neukum <oneukum@suse.de >
Reported-by: Grant Grundler <grundler@google.com >
Tested-by: Grant Grundler <grundler@google.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-04-14 06:42:18 -07:00
2013-05-17 14:31:05 -04:00
2014-03-06 21:30:03 -08:00
2014-03-31 09:58:12 -07:00
2013-05-04 12:31:18 -07:00
2013-07-25 14:07:23 -07:00
2013-05-05 17:36:20 -07:00
2013-05-17 00:42:33 +02:00
2013-05-11 16:12:44 -07:00
2013-05-06 15:41:42 -07:00
2013-12-04 10:56:22 -08:00
2013-05-14 13:40:45 +02:00
2013-05-25 20:30:31 -07:00
2013-05-13 18:27:18 +04:00
2013-08-14 22:59:08 -07:00
2014-04-14 06:42:18 -07:00
2013-05-14 10:23:57 +05:30
2013-05-30 10:51:20 -07:00
2013-05-07 19:46:02 -07:00
2014-02-13 13:48:00 -08:00
2014-01-09 12:24:22 -08:00
2013-10-13 16:08:33 -07:00
2013-11-29 11:11:44 -08:00
2014-04-03 12:01:04 -07:00
2013-05-08 10:13:35 -07:00
2013-05-08 10:13:35 -07:00
2013-05-15 14:42:15 -07:00
2013-05-01 08:04:12 -07:00
2013-07-21 18:21:25 -07:00
2013-12-08 07:29:27 -08:00
2013-05-02 09:03:55 -07:00
2014-02-13 13:48:00 -08:00
2014-02-22 12:41:29 -08:00
2013-12-20 07:45:10 -08:00
2013-05-31 11:32:30 +02:00
2013-07-25 14:07:42 -07:00
2013-06-12 16:29:44 -07:00
2013-05-11 15:23:17 -07:00
2013-05-01 17:51:54 -07:00
2013-10-18 07:45:45 -07:00
2013-10-05 07:13:11 -07:00
2013-05-01 13:20:04 -07:00
2013-05-01 16:36:22 +05:30
2013-05-02 21:52:26 +05:30
2013-07-28 16:30:11 -07:00
2013-08-20 08:43:03 -07:00
2013-05-07 18:38:27 -07:00
2013-05-01 17:31:42 -04:00
2013-06-10 22:23:32 -07:00
2014-03-23 21:38:16 -07:00
2013-06-20 19:02:45 +04:00
2014-03-31 09:58:12 -07:00
2013-05-09 20:10:22 -04:00
2013-12-11 22:36:28 -08:00
2013-10-13 16:08:28 -07:00
2014-04-03 12:01:05 -07:00
2014-02-06 11:08:12 -08:00
2013-05-08 11:51:05 -07:00
2013-06-12 00:56:27 -07:00
2013-07-28 16:30:05 -07:00
2013-05-02 12:10:19 +02:00
2014-03-06 21:30:12 -08:00
2013-09-14 06:54:55 -07:00
2014-03-23 21:38:20 -07:00
2013-05-13 09:45:01 -04:00
2013-05-24 16:22:51 -07:00
2013-12-20 07:45:08 -08:00
2013-05-16 07:55:07 -07:00
2013-05-31 11:32:30 +02:00
2014-02-06 11:08:16 -08:00
2013-05-05 10:58:06 -07:00
2013-05-31 17:31:52 -07:00
2013-06-12 16:29:47 -07:00
2013-10-13 16:08:35 -07:00
2014-01-09 12:24:23 -08:00
2014-04-03 12:01:05 -07:00
2013-11-29 11:11:53 -08:00
2013-12-04 10:56:10 -08:00
2013-07-21 18:21:29 -07:00
2014-01-15 15:28:47 -08:00
2013-05-02 07:34:58 -07:00
2014-03-06 21:30:05 -08:00
2013-05-23 11:58:55 +02:00
2013-05-01 15:00:24 -04:00
2013-05-06 17:24:22 -04:00
2013-05-04 14:47:26 -04:00
2013-05-08 09:55:05 -04:00
2013-05-02 21:50:38 +05:30
2013-05-07 11:22:14 -07:00
2013-09-26 17:18:14 -07:00
2013-05-17 14:12:06 -06:00
2013-05-01 14:08:52 -07:00
2013-05-28 11:05:08 +02:00
2013-05-07 20:16:25 -07:00
2014-02-13 13:47:59 -08:00
2013-05-05 13:23:27 -07:00
2013-06-19 12:55:10 +02:00
2013-05-22 01:34:24 +02:00
2013-05-01 17:29:47 -04:00
2013-05-01 17:29:39 -04:00
2013-12-08 07:29:24 -08:00
2013-06-02 20:53:59 -07:00
2013-09-26 17:18:13 -07:00
2013-05-28 22:47:13 -04:00
2013-09-07 22:09:58 -07:00
2013-05-24 16:22:50 -07:00
2013-05-24 16:22:50 -07:00
2013-05-30 09:20:20 +02:00
2013-11-29 11:11:44 -08:00
2013-10-18 07:45:47 -07:00
2013-09-26 17:18:13 -07:00
2014-03-06 21:30:05 -08:00
2013-05-06 09:24:16 +03:00
2013-06-14 19:24:42 -10:00
2013-06-06 11:52:14 -07:00
2014-01-09 12:24:23 -08:00
2013-06-20 19:02:45 +04:00
2013-06-12 16:29:46 -07:00
2013-08-20 08:43:02 -07:00
2013-06-12 16:29:44 -07:00
2013-05-09 09:40:49 -07:00
2013-11-29 11:11:42 -08:00
2013-08-11 18:35:24 -07:00
2013-05-14 20:54:06 +02:00
2013-10-01 09:17:45 -07:00
2014-03-23 21:38:16 -07:00
2013-05-11 14:29:11 -07:00
2013-05-20 10:24:22 +09:30
2013-11-13 12:05:29 +09:00
2013-08-11 18:35:25 -07:00
2013-07-28 16:29:55 -07:00
2013-12-08 07:29:27 -08:00
2014-02-13 13:48:00 -08:00
2013-05-20 12:15:59 -07:00
2013-05-31 11:31:50 +02:00
2013-08-29 09:47:39 -07:00
2013-05-07 20:16:25 -07:00
Oliver Neukum
2d4cf3d6f3