Al Viro 138c012118
fix fault_in_multipages_...() on architectures with no-op access_ok() ...
commit e23d4159b109167126e5bcd7f3775c95de7fee47 upstream.
Switching iov_iter fault-in to multipages variants has exposed an old
bug in underlying fault_in_multipages_...(); they break if the range
passed to them wraps around. Normally access_ok() done by callers will
prevent such (and it's a guaranteed EFAULT - ERR_PTR() values fall into
such a range and they should not point to any valid objects).
However, on architectures where userland and kernel live in different
MMU contexts (e.g. s390) access_ok() is a no-op and on those a range
with a wraparound can reach fault_in_multipages_...().
Since any wraparound means EFAULT there, the fix is trivial - turn
those
while (uaddr <= end)
...
into
if (unlikely(uaddr > end))
return -EFAULT;
do
...
while (uaddr <= end);
Reported-by: Jan Stancek <jstancek@redhat.com >
Tested-by: Jan Stancek <jstancek@redhat.com >
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
Signed-off-by: Willy Tarreau <w@1wt.eu >
2017-02-06 23:33:04 +01:00
2014-03-06 21:30:03 -08:00
2015-04-29 10:33:54 +02:00
2015-09-21 10:00:07 -07:00
2016-03-03 15:06:20 -08:00
2013-12-04 10:56:22 -08:00
2016-08-21 23:22:32 +02:00
2013-05-25 20:30:31 -07:00
2014-09-05 16:28:37 -07:00
2016-08-21 23:22:34 +02:00
2013-05-30 10:51:20 -07:00
2016-03-09 15:31:54 -08:00
2014-02-13 13:48:00 -08:00
2014-01-09 12:24:22 -08:00
2014-04-26 17:15:35 -07:00
2013-10-13 16:08:33 -07:00
2013-11-29 11:11:44 -08:00
2014-04-03 12:01:04 -07:00
2015-04-19 10:10:49 +02:00
2014-11-14 08:47:55 -08:00
2014-09-17 09:03:57 -07:00
2013-07-21 18:21:25 -07:00
2013-12-08 07:29:27 -08:00
2014-11-21 09:22:54 -08:00
2014-02-13 13:48:00 -08:00
2016-06-07 10:42:52 +02:00
2014-11-14 08:47:55 -08:00
2016-02-25 11:57:47 -08:00
2016-08-21 23:22:37 +02:00
2013-05-31 11:32:30 +02:00
2013-07-25 14:07:42 -07:00
2013-06-12 16:29:44 -07:00
2014-04-14 06:42:19 -07:00
2015-01-08 09:58:16 -08:00
2017-02-06 09:04:07 +01:00
2015-04-29 10:34:00 +02:00
2013-10-05 07:13:11 -07:00
2016-02-25 11:57:46 -08:00
2013-07-28 16:30:11 -07:00
2016-03-16 08:41:37 -07:00
2013-08-20 08:43:03 -07:00
2016-03-03 15:06:22 -08:00
2013-06-10 22:23:32 -07:00
2014-03-23 21:38:16 -07:00
2015-07-03 19:48:08 -07:00
2015-03-06 14:40:48 -08:00
2014-03-31 09:58:12 -07:00
2014-06-07 13:25:28 -07:00
2014-04-14 06:42:19 -07:00
2013-12-11 22:36:28 -08:00
2013-10-13 16:08:28 -07:00
2014-04-03 12:01:05 -07:00
2014-02-06 11:08:12 -08:00
2014-06-07 13:25:35 -07:00
2014-06-26 15:12:38 -04:00
2013-07-28 16:30:05 -07:00
2014-12-06 15:05:46 -08:00
2014-10-05 14:54:15 -07:00
2015-05-17 09:51:33 -07:00
2014-03-06 21:30:12 -08:00
2013-09-14 06:54:55 -07:00
2014-06-07 13:25:29 -07:00
2014-06-30 20:09:45 -07:00
2016-01-22 19:47:52 -08:00
2014-10-09 12:18:43 -07:00
2016-06-07 10:42:47 +02:00
2013-12-20 07:45:08 -08:00
2014-11-21 09:22:54 -08:00
2013-05-31 11:32:30 +02:00
2016-03-09 15:31:54 -08:00
2014-05-30 21:52:14 -07:00
2013-06-12 16:29:47 -07:00
2015-07-03 19:48:09 -07:00
2014-11-21 09:22:56 -08:00
2016-08-27 11:40:23 +02:00
2013-10-13 16:08:35 -07:00
2014-01-09 12:24:23 -08:00
2016-10-20 00:46:32 +02:00
2016-06-07 10:42:44 +02:00
2016-03-16 08:41:37 -07:00
2014-09-17 09:04:00 -07:00
2013-12-04 10:56:10 -08:00
2013-07-21 18:21:29 -07:00
2014-01-15 15:28:47 -08:00
2014-03-06 21:30:05 -08:00
2013-05-23 11:58:55 +02:00
2014-06-26 15:12:37 -04:00
2016-03-03 15:06:24 -08:00
2015-08-03 09:29:47 -07:00
2015-05-17 09:51:32 -07:00
2014-11-14 08:48:01 -08:00
2014-11-14 08:47:58 -08:00
2017-02-06 23:33:04 +01:00
2016-10-20 00:46:30 +02:00
2016-06-07 10:42:44 +02:00
2014-06-11 12:03:26 -07:00
2016-08-21 23:22:36 +02:00
2016-06-07 10:42:52 +02:00
2013-06-19 12:55:10 +02:00
2014-08-07 14:30:26 -07:00
2015-01-16 06:59:00 -08:00
2016-02-25 11:57:47 -08:00
2015-01-29 17:40:57 -08:00
2016-02-25 11:57:49 -08:00
2013-12-08 07:29:24 -08:00
2013-06-02 20:53:59 -07:00
2013-09-26 17:18:13 -07:00
2013-05-28 22:47:13 -04:00
2013-09-07 22:09:58 -07:00
2014-07-17 15:58:03 -07:00
2013-05-24 16:22:50 -07:00
2013-05-24 16:22:50 -07:00
2013-05-30 09:20:20 +02:00
2016-08-21 23:22:36 +02:00
2015-10-22 14:37:52 -07:00
2013-10-18 07:45:47 -07:00
2016-02-19 14:22:37 -08:00
2015-10-27 09:44:48 +09:00
2013-06-14 19:24:42 -10:00
2014-06-26 15:12:37 -04:00
2013-06-06 11:52:14 -07:00
2014-01-09 12:24:23 -08:00
2013-06-20 19:02:45 +04:00
2014-11-14 08:47:55 -08:00
2013-06-12 16:29:46 -07:00
2016-01-28 21:49:35 -08:00
2013-06-12 16:29:44 -07:00
2013-11-29 11:11:42 -08:00
2013-08-11 18:35:24 -07:00
2015-01-29 17:40:56 -08:00
2013-10-01 09:17:45 -07:00
2016-03-16 08:41:36 -07:00
2016-01-28 21:49:35 -08:00
2016-03-16 08:41:36 -07:00
2013-11-13 12:05:29 +09:00
2015-05-06 21:56:22 +02:00
2015-01-08 09:58:16 -08:00
2013-07-28 16:29:55 -07:00
2013-12-08 07:29:27 -08:00
2014-02-13 13:48:00 -08:00
2013-05-20 12:15:59 -07:00
2013-05-31 11:31:50 +02:00
2013-08-29 09:47:39 -07:00
2015-03-26 15:00:58 +01:00
Al Viro
138c012118