Dan Carpenter 7e20e7b991 libata: array underflow in ata_find_dev() ...

commit 59a5e266c3f5c1567508888dd61a45b86daed0fa upstream.

My static checker complains that "devno" can be negative, meaning that
we read before the start of the loop.  I've looked at the code, and I
think the warning is right.  This come from /proc so it's root only or
it would be quite a quite a serious bug.  The call tree looks like this:

proc_scsi_write() <- gets id and channel from simple_strtoul()
-> scsi_add_single_device() <- calls shost->transportt->user_scan()
   -> ata_scsi_user_scan()
      -> ata_find_dev()

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org # all versions at this point
Signed-off-by: Willy Tarreau <w@1wt.eu>

2017-11-01 22:12:44 +01:00

..

acard-ahci.c

libata: update "Maintained by:" tags

2013-05-14 11:13:04 -07:00

ahci_platform.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

ahci.c

ahci: Intel DNV device IDs SATA

2016-02-19 14:22:41 -08:00

ahci.h

libata: update "Maintained by:" tags

2013-05-14 11:13:04 -07:00

ata_generic.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

ata_piix.c

ata_piix: Add Device IDs for Intel 9 Series PCH

2014-10-05 14:54:13 -07:00

Kconfig

libata: make it clear that sata_inic162x is experimental

2013-08-04 16:50:55 +08:00

libahci.c

libata: disable forced PORTS_IMPL for >= AHCI 1.3

2016-02-19 14:22:41 -08:00

libata-acpi.c

libata-acpi: add back ACPI based hotplug functionality

2013-06-25 00:51:33 +02:00

libata-core.c

libata: force disable trim for SuperSSpeed S238

2015-08-03 09:29:45 -07:00

libata-eh.c

scsi: fix race between simultaneous decrements of ->host_failed

2016-08-27 11:40:28 +02:00

libata-pmp.c

ata: pmp: add quirk for Marvell 4140 SATA PMP

2015-08-10 12:20:31 -07:00

libata-scsi.c

libata: array underflow in ata_find_dev()

2017-11-01 22:12:44 +01:00

libata-sff.c

libata: fix sff host state machine locking while polling

2016-03-03 15:06:24 -08:00

libata-transport.c

libata: Fix display of sata speed

2013-12-04 10:55:51 -08:00

libata-transport.h

[libata] Add ATA transport class

2010-10-21 20:21:03 -04:00

libata-zpodd.c

libata-zpodd: must use ata_tf_init()

2013-07-25 14:07:27 -07:00

libata.h

libata-acpi: add back ACPI based hotplug functionality

2013-06-25 00:51:33 +02:00

Makefile

libata: add R-Car SATA driver

2013-02-20 17:10:53 -05:00

pata_acpi.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_ali.c

pata_ali: fix "Satelite" typo

2011-10-14 13:10:42 -04:00

pata_amd.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_arasan_cf.c

ata: arasan: remove the need for platform_data

2013-04-19 22:25:51 +02:00

pata_artop.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_at32.c

pata_at32: use module_platform_driver_probe()

2013-04-03 19:52:10 -04:00

pata_at91.c

pata_at91: fix ata_host_activate() failure handling

2014-06-07 13:25:29 -07:00

pata_atiixp.c

pata_atiixp: override cable detection on MSI E350DM-E33

2012-08-17 13:26:51 -04:00

pata_atp867x.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_bf54x.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

pata_cmd64x.c

ata: Convert dev_printk(KERN_<LEVEL> to dev_<level>(

2012-11-28 12:40:15 -05:00

pata_cmd640.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_cs5520.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

pata_cs5530.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_cs5535.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_cs5536.c

pata_cs5536: add quirk for broken udma

2012-11-28 12:38:41 -05:00

pata_cypress.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_efar.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_ep93xx.c

drivers/ata: don't check resource with devm_ioremap_resource

2013-05-12 15:19:46 +02:00

pata_hpt3x2n.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_hpt3x3.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_hpt37x.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_hpt366.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_icside.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

pata_imx.c

pata_imx: add devicetree support

2013-04-11 19:38:00 -04:00

pata_isapnp.c

[libata] Improve timeout handling

2009-03-24 22:52:39 -04:00

pata_it821x.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_it8213.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_ixp4xx_cf.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

pata_jmicron.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_legacy.c

pata_legacy: bogus clock in opti82c46x_set_piomode()

2013-04-03 19:53:10 -04:00

pata_macio.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

pata_marvell.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_mpc52xx.c

Merge remote-tracking branch 'agust/next' into next

2013-02-20 11:39:05 +11:00

pata_mpiix.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_netcell.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_ninja32.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_ns87410.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_ns87415.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_octeon_cf.c

pata_octeon_cf: fix broken build

2015-06-22 16:55:54 -07:00

pata_of_platform.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

pata_oldpiix.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_opti.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_optidma.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_palmld.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

pata_pcmcia.c

drivers/ata: use module_pcmcia_driver() in pcmcia drivers

2013-03-15 12:26:03 -07:00

pata_pdc202xx_old.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_pdc2027x.c

pata_pdc2027x: Fix compiler warning

2013-04-12 15:24:12 +02:00

pata_piccolo.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_platform.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

pata_pxa.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

pata_radisys.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_rb532_cf.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

pata_rdc.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

pata_rz1000.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_samsung_cf.c

pata_samsung_cf: use module_platform_driver_probe()

2013-03-04 17:12:52 -05:00

pata_sc1200.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_scc.c

pata_scc: propagate return value of scc_wait_after_reset

2014-10-05 14:54:07 -07:00

pata_sch.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

pata_serverworks.c

pata_serverworks: disable 64-KB DMA transfers on Broadcom OSB4 IDE Controller

2014-11-14 08:47:53 -08:00

pata_sil680.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

pata_sis.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_sl82c105.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_triflex.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pata_via.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

pdc_adma.c

libata: update "Maintained by:" tags

2013-05-14 11:13:04 -07:00

sata_dwc_460ex.c

sata_dwc_460ex: fix resource leak on error path

2015-01-29 17:40:56 -08:00

sata_fsl.c

sata_fsl: fix error handling of irq_of_parse_and_map

2014-12-16 09:09:42 -08:00

sata_highbank.c

sata_highbank: increase retry count but shorten duration for Calxeda controller

2013-07-25 14:07:28 -07:00

sata_inic162x.c

libata: make it clear that sata_inic162x is experimental

2013-08-04 16:50:55 +08:00

sata_mv.c

ata: sata_mv:- Handle return value of devm_ioremap.

2017-06-20 14:04:18 +02:00

sata_nv.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

sata_promise.c

libata: update "Maintained by:" tags

2013-05-14 11:13:04 -07:00

sata_promise.h

libata annotations and fixes

2008-01-23 05:24:15 -05:00

sata_qstor.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

sata_rcar.c

sata_rcar: fix interrupt handling

2013-06-02 00:54:45 -07:00

sata_sil24.c

sata_sil24: remove unused variable from sata_sil24.c

2012-11-28 12:39:20 -05:00

sata_sil.c

sata_sil: disable trim

2016-03-03 15:06:22 -08:00

sata_sis.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

sata_svw.c

sata_svw: switch to ->show_info()

2013-04-09 14:13:28 -04:00

sata_sx4.c

libata: update "Maintained by:" tags

2013-05-14 11:13:04 -07:00

sata_uli.c

ata: use module_pci_driver

2012-07-25 15:12:11 -04:00

sata_via.c

libata: update "Maintained by:" tags

2013-05-14 11:13:04 -07:00

sata_vsc.c

Drivers: ata: remove __dev* attributes.

2013-01-03 15:57:03 -08:00

sis.h

libata: PATA-mode fixes for sis_sata

2007-07-02 10:17:42 -04:00